From e58b92b0cd1e2bc798fd1268936ddc225a648457 Mon Sep 17 00:00:00 2001 From: Bart Louwers Date: Fri, 4 Jul 2025 22:21:56 +0200 Subject: [PATCH] Remove react autobind (#1254) ## Launch Checklist Remove react-autobind dependency - [x] Briefly describe the changes in this PR. - [ ] Link to related issues. - [ ] Include before/after visuals or gifs if this PR includes visual changes. - [ ] Write tests for all new functionality. - [x] Add an entry to `CHANGELOG.md` under the `## main` section. --- CHANGELOG.md | 1 + package-lock.json | 6 ------ package.json | 1 - src/components/App.tsx | 3 --- 4 files changed, 1 insertion(+), 10 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c6f88950..8bedd0d0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ - Upgrade Vite 6 and Cypress 14 ([#970](https://github.com/maplibre/maputnik/pull/970)) - Upgrade OpenLayers from v6 to v10 - When loading a style into localStorage that causes a QuotaExceededError, purge localStorage and retry +- Remove react-autobind dependency - _...Add new stuff here..._ ### 🐞 Bug fixes diff --git a/package-lock.json b/package-lock.json index a0814469..186c46d7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -46,7 +46,6 @@ "react-accessible-accordion": "^5.0.1", "react-aria-menubutton": "^7.0.3", "react-aria-modal": "^5.0.2", - "react-autobind": "^1.0.6", "react-autocomplete": "^1.8.1", "react-collapse": "^5.1.1", "react-color": "^2.19.3", @@ -10772,11 +10771,6 @@ "react-dom": ">=16.3.0" } }, - "node_modules/react-autobind": { - "version": "1.0.6", - "resolved": "https://registry.npmjs.org/react-autobind/-/react-autobind-1.0.6.tgz", - "integrity": "sha512-+BTreuQUUGv1Tv4GbcFNk+1L8U60ZSdxLUs3OVUPsShzxLFYcTYcNf2wzMt3GEU4iFA8Px7SpofpX+uiL03QyQ==" - }, "node_modules/react-autocomplete": { "version": "1.8.1", "resolved": "https://registry.npmjs.org/react-autocomplete/-/react-autocomplete-1.8.1.tgz", diff --git a/package.json b/package.json index c637a362..5d1541db 100644 --- a/package.json +++ b/package.json @@ -60,7 +60,6 @@ "react-accessible-accordion": "^5.0.1", "react-aria-menubutton": "^7.0.3", "react-aria-modal": "^5.0.2", - "react-autobind": "^1.0.6", "react-autocomplete": "^1.8.1", "react-collapse": "^5.1.1", "react-color": "^2.19.3", diff --git a/src/components/App.tsx b/src/components/App.tsx index fcee5f93..68bd8eb3 100644 --- a/src/components/App.tsx +++ b/src/components/App.tsx @@ -1,5 +1,3 @@ -// @ts-ignore - this can be easily replaced with arrow functions -import autoBind from 'react-autobind'; import React from 'react' import cloneDeep from 'lodash.clonedeep' import clamp from 'lodash.clamp' @@ -140,7 +138,6 @@ export default class App extends React.Component { constructor(props: any) { super(props) - autoBind(this); this.revisionStore = new RevisionStore() const params = new URLSearchParams(window.location.search.substring(1))