From bf4686b3d47c9688e08b14eccfe9b20498f0504c Mon Sep 17 00:00:00 2001
From: Ian Wagner <ian.wagner@stadiamaps.com>
Date: Fri, 20 Sep 2024 18:53:03 +0900
Subject: [PATCH] Fix usability of hyperlinks

---
 src/components/Block.tsx | 4 +++-
 src/components/Doc.tsx   | 9 +++++----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/components/Block.tsx b/src/components/Block.tsx
index 1f37d9ce..63d6635f 100644
--- a/src/components/Block.tsx
+++ b/src/components/Block.tsx
@@ -56,7 +56,9 @@ export default class Block extends React.Component<BlockProps, BlockState> {
     if (event.nativeEvent.target.nodeName !== "INPUT" && !contains) {
       event.stopPropagation();
     }
-    event.preventDefault();
+    if (event.nativeEvent.target.nodeName !== "A") {
+      event.preventDefault();
+    }
   }
 
   render() {
diff --git a/src/components/Doc.tsx b/src/components/Doc.tsx
index 6a5949b9..d54a23d2 100644
--- a/src/components/Doc.tsx
+++ b/src/components/Doc.tsx
@@ -18,7 +18,8 @@ type DocProps = {
     'sdk-support'?: {
       [key: string]: typeof headers
     }
-    docUrl?: string
+    docUrl?: string,
+    docUrlDescription?: string
   }
 };  // & WithTranslation?
 
@@ -26,7 +27,7 @@ export default class Doc extends React.Component<DocProps> {
   render () {
     const {fieldSpec} = this.props;
 
-    const {doc, values, docUrl} = fieldSpec;
+    const {doc, values, docUrl, docUrlDescription} = fieldSpec;
     const sdkSupport = fieldSpec['sdk-support'];
 
     const renderValues = (
@@ -86,9 +87,9 @@ export default class Doc extends React.Component<DocProps> {
             </table>
           </div>
         }
-        {docUrl &&
+        {docUrl && docUrlDescription &&
           <div className="SpecDoc__learn-more">
-            <a href={docUrl}  target="_blank" rel="noreferrer" onClick={() => console.log('Link clicked')}>Learn More (TODO i18n)</a>
+            <a href={docUrl}  target="_blank" rel="noreferrer" onClick={() => console.log('Link clicked')}>{docUrlDescription}</a>
           </div>
         }
       </>