Add lint to CI and fix errors (#853)

Adds lint to CI and fixes errors.
I'm not sure I'm fully proud of all the solutions there.
But there's no lint issues and the lint is being checked as part of the
CI.

---------

Co-authored-by: Yuri Astrakhan <yuriastrakhan@gmail.com>

src/libs/apistore.ts

@@ -29,18 +29,18 @@ export class ApiStyleStore {
     fetch(this.localUrl + '/styles', {
       mode: 'cors',
     })
-    .then((response) =>  {
-      return response.json();
-    })
-    .then((body) => {
-      const styleIds = body;
-      this.latestStyleId = styleIds[0]
-      this.notifyLocalChanges()
-      cb(null)
-    })
-    .catch(() => {
-      cb(new Error('Can not connect to style API'))
-    })
+      .then((response) =>  {
+        return response.json();
+      })
+      .then((body) => {
+        const styleIds = body;
+        this.latestStyleId = styleIds[0]
+        this.notifyLocalChanges()
+        cb(null)
+      })
+      .catch(() => {
+        cb(new Error('Can not connect to style API'))
+      })
   }
 
   notifyLocalChanges() {
@@ -64,12 +64,12 @@ export class ApiStyleStore {
       fetch(this.localUrl + '/styles/' + this.latestStyleId, {
         mode: 'cors',
       })
-      .then(function(response) {
-        return response.json();
-      })
-      .then(function(body) {
-        cb(style.ensureStyleValidity(body))
-      })
+        .then(function(response) {
+          return response.json();
+        })
+        .then(function(body) {
+          cb(style.ensureStyleValidity(body))
+        })
     } else {
       throw new Error('No latest style available. You need to init the api backend first.')
     }
@@ -92,9 +92,9 @@ export class ApiStyleStore {
       },
       body: styleJSON
     })
-    .catch(function(error) {
-      if(error) console.error(error)
-    })
+      .catch(function(error) {
+        if(error) console.error(error)
+      })
     return mapStyle
   }
 }

src/libs/debug.ts

@@ -33,7 +33,7 @@ function get(namespace: keyof DebugStore, key: string) {
   if(!enabled()) {
     throw genErr();
   }
-  if(debugStore.hasOwnProperty(namespace)) {
+  if(Object.prototype.hasOwnProperty.call(debugStore, namespace)) {
     return debugStore[namespace][key];
   }
 }

src/libs/layer.ts

@@ -70,3 +70,21 @@ export function changeProperty(layer: LayerSpecification, group: keyof LayerSpec
     }
   }
 }
+
+export function layerPrefix(name: string) {
+  return name.replace(' ', '-').replace('_', '-').split('-')[0]
+}
+
+export function findClosestCommonPrefix(layers: LayerSpecification[], idx: number) {
+  const currentLayerPrefix = layerPrefix(layers[idx].id)
+  let closestIdx = idx
+  for (let i = idx; i > 0; i--) {
+    const previousLayerPrefix = layerPrefix(layers[i-1].id)
+    if(previousLayerPrefix === currentLayerPrefix) {
+      closestIdx = i - 1
+    } else {
+      return closestIdx
+    }
+  }
+  return closestIdx
+}

src/libs/metadata.ts

@@ -5,16 +5,16 @@ function loadJSON(url: string, defaultValue: any, cb: (...args: any[]) => void)
     mode: 'cors',
     credentials: "same-origin"
   })
-  .then(function(response) {
-    return response.json();
-  })
-  .then(function(body) {
-    cb(body)
-  })
-  .catch(function() {
-    console.warn('Can not metadata for ' + url)
-    cb(defaultValue)
-  })
+    .then(function(response) {
+      return response.json();
+    })
+    .then(function(body) {
+      cb(body)
+    })
+    .catch(function() {
+      console.warn('Can not metadata for ' + url)
+      cb(defaultValue)
+    })
 }
 
 export function downloadGlyphsMetadata(urlTemplate: string, cb: (...args: any[]) => void) {
@@ -22,14 +22,14 @@ export function downloadGlyphsMetadata(urlTemplate: string, cb: (...args: any[])
 
   // Special handling because Tileserver GL serves the fontstacks metadata differently
   // https://github.com/klokantech/tileserver-gl/pull/104#issuecomment-274444087
-  let urlObj = npmurl.parse(urlTemplate);
+  const urlObj = npmurl.parse(urlTemplate);
   const normPathPart = '/%7Bfontstack%7D/%7Brange%7D.pbf';
   if(urlObj.pathname === normPathPart) {
     urlObj.pathname = '/fontstacks.json';
   } else {
     urlObj.pathname = urlObj.pathname!.replace(normPathPart, '.json');
   }
-  let url = npmurl.format(urlObj);
+  const url = npmurl.format(urlObj);
 
   loadJSON(url, [], cb)
 }

src/libs/stylestore.ts

@@ -21,10 +21,10 @@ export function loadDefaultStyle(cb: (...args: any[]) => void) {
 function loadStoredStyles() {
   const styles = []
   for (let i = 0; i < window.localStorage.length; i++) {
-      const key = window.localStorage.key(i)
-      if(isStyleKey(key!)) {
-        styles.push(fromKey(key!))
-      }
+    const key = window.localStorage.key(i)
+    if(isStyleKey(key!)) {
+      styles.push(fromKey(key!))
+    }
   }
   return styles
 }
@@ -70,10 +70,10 @@ export class StyleStore {
   // Delete entire style history
   purge() {
     for (let i = 0; i < window.localStorage.length; i++) {
-        const key = window.localStorage.key(i) as string;
-        if(key.startsWith(storagePrefix)) {
-          window.localStorage.removeItem(key)
-        }
+      const key = window.localStorage.key(i) as string;
+      if(key.startsWith(storagePrefix)) {
+        window.localStorage.removeItem(key)
+      }
     }
   }
 

src/libs/urlopen.ts

@@ -12,16 +12,16 @@ export function loadStyleUrl(styleUrl: string, cb: (...args: any[]) => void) {
     mode: 'cors',
     credentials: "same-origin"
   })
-  .then(function(response) {
-    return response.json();
-  })
-  .then(function(body) {
-    cb(style.ensureStyleValidity(body))
-  })
-  .catch(function() {
-    console.warn('Could not fetch default style', styleUrl)
-    cb(style.emptyStyle)
-  })
+    .then(function(response) {
+      return response.json();
+    })
+    .then(function(body) {
+      cb(style.ensureStyleValidity(body))
+    })
+    .catch(function() {
+      console.warn('Could not fetch default style', styleUrl)
+      cb(style.emptyStyle)
+    })
 }
 
 export function removeStyleQuerystring() {