ashatora/editor
1
0
Fork 0
mirror of https://github.com/maputnik/editor.git synced 2026-07-19 12:27:26 +00:00
Code Issues Projects Releases Wiki Activity

Fix <NumberInput/> to allow for empty value (reset value)

Browse Source
This commit is contained in:
orangemug
2019-10-13 18:00:32 +01:00
parent 00ab303e44
commit 3eabcbec72
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/inputs/NumberInput.jsx
+7 -1
View File
@@ -28,7 +28,9 @@ class NumberInput extends React.Component {
changeValue(newValue) { changeValue(newValue) {
this.setState({editing: true}); this.setState({editing: true});
const value = parseFloat(newValue) const value = (newValue === "" || newValue === undefined) ?
undefined :
parseFloat(newValue);
const hasChanged = this.state.value !== value const hasChanged = this.state.value !== value
if(this.isValid(value) && hasChanged) { if(this.isValid(value) && hasChanged) {
@@ -38,6 +40,10 @@ class NumberInput extends React.Component {
} }
isValid(v) { isValid(v) {
if (v === undefined) {
return true;
}
const value = parseFloat(v) const value = parseFloat(v)
if(isNaN(value)) { if(isNaN(value)) {
return false return false