ashatora/editor
1
0
Fork 0
mirror of https://github.com/maputnik/editor.git synced 2026-01-07 14:00:01 +00:00
Code Issues Projects Releases Wiki Activity

Only update if structure of JSON changes

Browse Source
This commit is contained in:
Lukas Martinelli
2016-12-29 21:49:40 +01:00
parent ae9afdd8d9
commit 3be3a716d4
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/components/layers/JSONEditor.jsx
View File

@@ -32,12 +32,24 @@ class JSONEditor extends React.Component {
}) })
} }
shouldComponentUpdate(nextProps, nextState) {
try {
const parsedLayer = JSON.parse(this.state.code)
// If the structure is still the same do not update
// because it affects editing experience by reformatting all the time
return nextState.code !== JSON.stringify(parsedLayer, null, 2)
} catch(err) {
return true
}
}
onCodeUpdate(newCode) { onCodeUpdate(newCode) {
try { try {
const parsedLayer = JSON.parse(newCode) const parsedLayer = JSON.parse(newCode)
this.props.onChange(parsedLayer) this.props.onChange(parsedLayer)
} catch(err) { } catch(err) {
console.warn(err) console.warn(err)
} finally {
this.setState({ this.setState({
code: newCode code: newCode
}) })