ashatora/editor
1
0
Fork 0
mirror of https://github.com/maputnik/editor.git synced 2026-06-06 15:27:30 +00:00
Code Issues Projects Releases Wiki Activity

Use driver pattern for e2e tests (#829)

Browse Source 
I've moved all the logic relevant to WBIO into a single file in order to
be able to replace it.
I have tried to upgrade WDIO in order to use the latest version and it
got stuck on my computer.
Furthermore, I was not able to run it locally which made this whole
cycle very long.
After this will be merged I will replace WDIO with cypress.
This doesn't change anything, only moves some code in the tests to a
single file, removes unneeded files and uses the driver pattern, which
will later allow switching the underline WDIO with Cypress.

cc: @nyurik
This commit is contained in:
Harel M
2023-12-17 08:14:23 +02:00
committed by GitHub
parent 31d56c9fae
commit 18f45e932b
15 changed files with 490 additions and 605 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/functional/history/index.js
+22 -31
View File
@@ -1,8 +1,5 @@
var assert = require("assert");
var config = require("../../config/specs");
var helper = require("../helper");
var driver = require("../driver");
describe("history", function() {
let undoKeyCombo;
@@ -11,9 +8,7 @@ describe("history", function() {
let redoKeyComboReset;
before(async function() {
const isMac = await browser.execute(function() {
return navigator.platform.toUpperCase().indexOf('MAC') >= 0;
});
const isMac = await driver.isMac();
undoKeyCombo = ['Meta', 'z'];
undoKeyComboReset = ['Meta'];
redoKeyCombo = isMac ? ['Meta', 'Shift', 'z'] : ['Meta', 'y'];
@@ -26,22 +21,18 @@ describe("history", function() {
it.skip("undo/redo", async function() {
var styleObj;
await browser.url(config.baseUrl+"?debug&style="+helper.getStyleUrl([
"geojson:example"
]));
await browser.acceptAlert();
await driver.setStyle(["geojson:example"])
await driver.openLayersModal();
await helper.modal.addLayer.open();
styleObj = await helper.getStyleStore(browser);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, []);
await helper.modal.addLayer.fill({
await driver.fillLayersModal({
id: "step 1",
type: "background"
})
styleObj = await helper.getStyleStore(browser);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
{
"id": "step 1",
@@ -49,13 +40,13 @@ describe("history", function() {
}
]);
await helper.modal.addLayer.open();
await helper.modal.addLayer.fill({
await driver.openLayersModal();
await driver.fillLayersModal({
id: "step 2",
type: "background"
})
styleObj = await helper.getStyleStore(browser);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
{
"id": "step 1",
@@ -67,9 +58,9 @@ describe("history", function() {
}
]);
await browser.keys(undoKeyCombo)
await browser.keys(undoKeyComboReset);
styleObj = await helper.getStyleStore(browser);
await driver.typeKeys(undoKeyCombo);
await driver.typeKeys(undoKeyComboReset);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
{
"id": "step 1",
@@ -77,15 +68,15 @@ describe("history", function() {
}
]);
await browser.keys(undoKeyCombo)
await browser.keys(undoKeyComboReset);
styleObj = await helper.getStyleStore(browser);
await driver.typeKeys(undoKeyCombo)
await driver.typeKeys(undoKeyComboReset);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
]);
await browser.keys(redoKeyCombo)
await browser.keys(redoKeyComboReset);
styleObj = await helper.getStyleStore(browser);
await driver.typeKeys(redoKeyCombo)
await driver.typeKeys(redoKeyComboReset);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
{
"id": "step 1",
@@ -93,9 +84,9 @@ describe("history", function() {
}
]);
await browser.keys(redoKeyCombo)
await browser.keys(redoKeyComboReset);
styleObj = await helper.getStyleStore(browser);
await driver.typeKeys(redoKeyCombo)
await driver.typeKeys(redoKeyComboReset);
styleObj = await driver.getStyleStore();
assert.deepEqual(styleObj.layers, [
{
"id": "step 1",